Replace Exception with Test

Replace Exception with Test

You are throwing an exception on a condition the caller could have checked first.

Change the caller to make the test first.

        double getValueForPeriod (int periodNumber) {
                try {
                        return _values[periodNumber];
                } catch (ArrayIndexOutOfBoundsException e) {
                        return 0;
                }
        }


        double getValueForPeriod (int periodNumber) {
                if (periodNumber >= _values.length) return 0;
                return _values[periodNumber];
        }


For more information see page 315 of Refactoring




***** 아름다운프로님에 의해서 게시물 복사 + 카테고리변경되었습니다 (2003-12-18 17:27)